Comments on: Programming Brain Teaser

By: Terry Riegel

Terry Riegel — Mon, 10 Nov 2008 21:50:05 +0000

Your code leaves extraneous [strong][/strong] tags when there are only 2 letters. It would leave something like

abcc[strong][/strong]dee[strong]eee[/strong]…

I used square brackets as I am not sure the regular brackets would make it into the comment

By: EngLee

EngLee — Wed, 09 Jul 2008 02:44:24 +0000

I agree with you. But, hey, you were only optimizing my code. Your are like simplifying mathematics formulas.

I’m sure you will get something different if you were to work from the question.

Anyway, it’s always better to optimize codings, which I didn’t do. I only tried to make it work.

By: gbyeow

gbyeow — Wed, 09 Jul 2008 02:37:19 +0000

Well, I would save myself some if statements and comparisons. Does the same thing. It doesn't make the code any more concise or easier to read:

foreach ($arr as $item) {
	if ($prev == $item) {
		$count ++;
		if ($count == 2) echo '';
	} else {
		if ($count >= 2) echo '';
		$count = 0;
	}
	echo $item;
	$prev = $item;
}